Disqus - Latest Comments for tehlike

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Fri, 26 Dec 2008 17:54:16 -0000

Well, now I understand what you mean. Yes, I would also go with Bootstrapper, register AppSettings["apikey"] thing as a dependency for AkismetSevice.

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Fri, 26 Dec 2008 14:55:38 -0000

Does structure map support xml config? I assumed it does, configuring it there may not be good, because it should be set during compiletime, which means this should be recompiled. If it supports xml, it is better to mix this(or better have your own configuration scheme, but this may not be as beneficial) otherwise AppSettings seems to be the way to go.

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Tue, 23 Dec 2008 18:08:20 -0000

Join me, maybe ? :)

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Tue, 23 Dec 2008 10:04:16 -0000

Rob, some little things I have noticed:

1. Instead of using System.Configuration.ConfigurationManager.AppSettings as the store for wordpress api key, wouldn't it be better to have it injected, to increase easier testability? (The same thing goes with AccountController:OpenId)
I _believe_ it is better to have something like IAuthenticationProvider to hide OpenId details, it's place, imho, is not the controller.
And also passing "localhost" may not be a good thing, but it doesn't matter much.

2.I am not sure if this returns null ever (in LocalizationService)
List<phrase> result= (from p in _phraseRepo.GetPhrases()
where p.LanguageCode == languageCode
select p).ToList();
By convention, it should return a list with no element.

3. I believe(no strong thoughts on that)

public LazyList<tag> Tags { get; set; }

I would personally return IList<tag> for the sake of abstraction.(even though it hides some detail)

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Sat, 20 Dec 2008 18:42:07 -0000

No, definitely not a push back! I like to discuss about software as it is a great way to learn.
The thing that me and you differentiate at is (probably) that I am thinking a little further, and trying to provide extension mechanism at the beginning, while you are doing things as you come across, ie iteratively. Maybe you would do this my way when needs require this.

On the other hand, I still think that Spam Check is better to be a seperate concern and this seperation brings more flexibility.

Anyway, I started to repeat myself, I probably cannot find the right technical term for this issue.

I liked this discussion as it made me think again and again. Thanks, Rob!

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Sat, 20 Dec 2008 17:46:54 -0000

Actually I think we both understand each other, and I really get what you mean, but i am probably failing at some points that i want to tell. If I can tidy up my mind and can find time, I am glad to write on my point, maybe I will have to agree with you if I think densely on that, who knows? :)

Thanks for you attention, Rob. I really appreciate it.

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Sat, 20 Dec 2008 16:41:28 -0000

This is what business layer is for, correct but you can divide business into several points too. Isn't having a hook makes the design more clear? And you remove one concern from your business to another point, with a bonus of extensibility.
You can wire up the events using containers, this is a piece of cake.

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Sat, 20 Dec 2008 15:22:11 -0000

Hi Rob, Thanks for the attention. I said Decoupling but it was my fault, now I say SRP.
My reasoning is that spam service is one of the many possibilities that can be done with the comment. Other possibilities, for example, are sending a notification to the author of the post that there is a new comment etc. Thinking on those, I see that adding those new actions to the controller would be ugly and an indicator of SRP, too. If you use event handlers, new handlers can easily be attached, and you'll have cleaner code.

Re: Oxite Refactor, Take 1 : Rob Conery

Tuna Toksoz — Sat, 20 Dec 2008 13:55:17 -0000

Rob,
I believe Akismet implementation shouldn't be in Create action in CommentController. I would decouple it to have more flexible code.
Here is my thoughts:
http://tunatoksoz.com/post/...

Thanks for your attention